代码检查

ebike-gateway/src/main/java/com/cdzy/gateway/filters/CustomCipherTextFilter.java

@@ -136,8 +136,6 @@ public class CustomCipherTextFilter implements GlobalFilter, Ordered {
 //                                log.error("密文过滤器加解密错误", e);
 //                                return Mono.empty();
                     return chain.filter(exchange);
-                } finally {
-
                 }
             }
         }

ebike-gather/src/main/java/org/cdzy/gather/config/MqttConfig.java

@@ -33,13 +33,13 @@ public class MqttConfig {
 
     // 连接池参数
     @Getter
-    private static int poolMaxTotal = 20;
+    private static final int poolMaxTotal = 20;
 
     @Getter
-    private static int poolMaxIdle = 10;
+    private static final int poolMaxIdle = 10;
 
     @Getter
-    private static int poolMinIdle = 5;
+    private static final int poolMinIdle = 5;
 
     @Value("${mqtt.host}")
     public void setHost(String host) {

ebike-maintenance/src/main/java/com/cdzy/ebikemaintenance/service/impl/EbikeUsersSever.java

@@ -21,11 +21,7 @@ public class EbikeUsersSever {
         queryWrapper.eq("phone", username);
 //        queryWrapper.eq("password", password);
         long l = ebikeUsersMapper.selectCountByQuery(queryWrapper);
-        if (l > 0) {
+        return l > 0;
-            return true;
-        } else{
-            return false;
-        }
     }
 
     public EbikeUsers getUserInfo (String username, String password){

ebike-operate/src/main/java/com/cdzy/ebikeoperate/model/dto/request/ReqEbikeComponentEnterRecordsDto.java

@@ -22,7 +22,7 @@ public class ReqEbikeComponentEnterRecordsDto {
     private String region;
     /**
      * 部件类型
-     */;
+     */
     private String componentType;
     /**
      * 状态

ebike-operate/src/main/java/com/cdzy/ebikeoperate/model/dto/request/ReqEbikeComponentOutRecordsDto.java

@@ -22,7 +22,7 @@ public class ReqEbikeComponentOutRecordsDto {
     private String region;
     /**
      * 部件类型
-     */;
+     */
     private String componentType;
 
     /**

ebike-operate/src/main/java/com/cdzy/ebikeoperate/model/dto/request/ReqEbikeComponentProductionDto.java

@@ -22,7 +22,7 @@ public class ReqEbikeComponentProductionDto {
     private String region;
     /**
      * 部件类型
-     */;
+     */
     private String componentType;
     /**
      * 供应商

ebike-operate/src/main/java/com/cdzy/ebikeoperate/utils/RedisUtil.java

@@ -400,7 +400,7 @@ public class RedisUtil {
      * @param areaId areaId
      */
     public String getPolygonFromWKT(Long suffixId,String areaId,String key) {
-        return "POLYGON ((" + (String)redisTemplate.opsForHash().get(key + suffixId, "vertices"+areaId)+"))";
+        return "POLYGON ((" + redisTemplate.opsForHash().get(key + suffixId, "vertices"+areaId) +"))";
     }
 
     /**

ebike-orders/src/main/java/com/cdzy/orders/uitls/RedisUtil.java

@@ -407,7 +407,7 @@ public class RedisUtil {
      * @param areaId areaId
      */
     public String getPolygonFromWKT(Long orgId, String areaId, String key) {
-        return "POLYGON ((" + (String) redisTemplate.opsForHash().get(key + orgId, "vertices" + areaId) + "))";
+        return "POLYGON ((" + redisTemplate.opsForHash().get(key + orgId, "vertices" + areaId) + "))";
     }
 
     /**
@@ -417,7 +417,7 @@ public class RedisUtil {
      * @param areaId areaId
      */
     public String getPolygonFromWKT(String areaId, String key) {
-        return "POLYGON ((" + (String) redisTemplate.opsForHash().get(key, "vertices" + areaId) + "))";
+        return "POLYGON ((" + redisTemplate.opsForHash().get(key, "vertices" + areaId) + "))";
     }
 
     /**

ebike-payment/src/main/java/com/cdzy/payment/model/dto/ResApplyRefundDto.java

@@ -80,7 +80,6 @@ public class ResApplyRefundDto {
      * 骑行设备编号
      */
     private String ebikeCode;
-    ;
 
     /**
      * 骑行开始时间

ebike-payment/src/main/java/com/cdzy/payment/model/dto/ResCloseRefundDto.java

@@ -89,7 +89,7 @@ public class ResCloseRefundDto {
     /**
      * 骑行设备编号
      */
-    private String ebikeCode;;
+    private String ebikeCode;
 
     /**
      * 骑行开始时间

ebike-payment/src/main/java/com/cdzy/payment/model/dto/ResHandleRefundDto.java

@@ -84,7 +84,7 @@ public class ResHandleRefundDto {
     /**
      * 骑行设备编号
      */
-    private String ebikeCode;;
+    private String ebikeCode;
 
     /**
      * 骑行开始时间

ebike-payment/src/main/java/com/cdzy/payment/model/dto/ResProcessedRefundDto.java

@@ -110,7 +110,6 @@ public class ResProcessedRefundDto {
      * 骑行设备编号
      */
     private String ebikeCode;
-    ;
 
     /**
      * 骑行开始时间

ebike-payment/src/main/java/com/cdzy/payment/service/impl/EbikePaymentServiceImpl.java

@@ -36,7 +36,7 @@ public class EbikePaymentServiceImpl extends ServiceImpl<EbikePaymentMapper, Ebi
     public List<EbikePayment> getNoPayOrderByDuration(int duration) {
         // trade_state 等于 NOTPAY未支付的， 并且创建时间未超过duration分钟的订单
         String timeFilter = String.format("%s(%s, %s(%s))<%s()", ADDTIME, EBIKE_PAYMENT.CREATE_TIME.getName(), SEC_TO_TIME
-                , String.valueOf(duration * 60), NOW);
+                , duration * 60, NOW);
         QueryWrapper query = QueryWrapper.create()
                 .where(EBIKE_PAYMENT.TRADE_STATE.eq(Transaction.TradeStateEnum.NOTPAY.ordinal()))
                 .and(timeFilter);
@@ -47,7 +47,7 @@ public class EbikePaymentServiceImpl extends ServiceImpl<EbikePaymentMapper, Ebi
     public List<EbikePayment> getExpireOrderByDuration(int duration) {
         // trade_state 等于 NOTPAY未支付的， 并且创建时间超过duration分钟的订单
         String timeFilter = String.format("%s(%s, %s(%s))>=%s()", ADDTIME, EBIKE_PAYMENT.CREATE_TIME.getName(), SEC_TO_TIME
-                , String.valueOf(duration * 60), NOW);
+                , duration * 60, NOW);
         QueryWrapper query = QueryWrapper.create()
                 .where(EBIKE_PAYMENT.TRADE_STATE.eq(Transaction.TradeStateEnum.NOTPAY.ordinal()))
                 .and(timeFilter);

ebike-payment/src/main/java/com/cdzy/payment/service/impl/EbikeRefundServiceImpl.java

@@ -50,7 +50,7 @@ public class EbikeRefundServiceImpl extends ServiceImpl<EbikeRefundMapper, Ebike
     public List<EbikeRefund> getNoSuccessRefundOrderByDuration(int duration) {
         // trade_state 等于 PROCESSING正在退款中的， 并且创建时间超过duration分钟的订单
         String timeFilter = String.format("%s(%s, %s(%s))>=%s()", ADDTIME, EBIKE_REFUND.CREATE_TIME.getName(), SEC_TO_TIME
-                , String.valueOf(duration * 60), NOW);
+                , duration * 60, NOW);
         QueryWrapper query = QueryWrapper.create()
                 .where(EBIKE_REFUND.STATUS.eq(Status.PROCESSING.ordinal()))
                 .and(timeFilter);